Repository navigation
Conversation
|
@DataDog review |
There was a problem hiding this comment.
The REST endpoint returns lowercase open, so the retained OPEN guard tells the babysitter to stop on an open PR. The rewritten poll also omits explicit top-level feedback polling and pagination of commit-status contexts.
🤖 Bits Code Review · Commit 4a30bbf
CI Test ResultsRun: #45072103481 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-11-22 21:51:22 UTC |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a30bbf818
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
The REST conversion retains uppercase OPEN guards, causing the babysitter to stop on open PRs. It also truncates commit-status contexts and removes explicit polling of top-level review feedback.
🤖 Bits Code Review · Commit 4a30bbf
…, paginate status contexts (PROF-16822)
…mment surfaces (PROF-16822)
…rfaces (PROF-16822)
4a30bbf to
d2cb116
Compare
|
@DataDog review |
There was a problem hiding this comment.
The new failure rule classifies unfinished checks with null conclusions as red, potentially triggering failure handling and preventing idle backoff. A completion guard separates pending checks from failed checks.
🤖 Bits Code Review · Commit d2cb116
There was a problem hiding this comment.
More details
The specialist verified the REST reads against the reviewed head and returned no actionable findings. The full polling loop remains untested, and GraphQL permissions prevented comparison with gh pr checks.
🤖 Bits Code Review · Commit d2cb116
|
❌ 38 passed, 0 failed, 2 without a result out of 40 expected configurations Test Matrix
No result producedThese configurations wrote no validation log, so their outcome is unknown and
Links
|
|
🐶 babysit-pr is watching this PR — CI breakages and mechanical findings are fixed and pushed automatically; design decisions are always brought to you. This run
Commits pushed: none (all findings were either already fixed on the current head or outside the worker's edit scope). Findings flagged: P2 on ✅ stopped 20:00 UTC · CI green on |
|
🐶 babysit-pr is watching this PR — CI breakages and mechanical findings are fixed and pushed automatically; design decisions are always brought to you. This run
Commits pushed: none — nothing inside the workers edit scope broke; the only red is the external ✅ stopped 21:21 UTC · blocked on CI infra (JDK8 download outage, retries exhausted, also red on main) · 0 commits pushed · 1 Bits finding flagged to the session |
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 3 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 47cd7b4 | Docs | View more details | Give us feedback! |
|
@DataDog review |
There was a problem hiding this comment.
Deduplicating checks by started_at can discard a queued replacement, allowing stale CI results to drive remediation or a premature stop.
🤖 Bits Code Review · Commit a29b49a
…erral clause (PROF-16822)
|
🐶 babysit-pr is watching this PR — CI breakages and mechanical findings are fixed and pushed automatically; design decisions are always brought to you. This run
✅ stopped 22:21 UTC · blocked on CI infra (JDK8 download outage) — all checks green except the known-outage aggregators; Bits PASS on 47cd7b4
Stop summary — no commits pushed this run (no fixable CI failures; the only reds are the persistent JDK8-download infra outage). Findings answered: 1 — Bits P2 thread on SKILL.md dedupe wording (root 4660041761), harm premise refuted on the thread; the residual wording nit is flagged to the session owner (skill file, never worker-edited). Threads left for the author: that SKILL.md wording nit (meta-file fix is the session's call). |
|
@DataDog review |
There was a problem hiding this comment.
More details
The REST polling instructions preserve pending-check handling and all three comment and review sources. The completed static review found no actionable regression in the supplied diff.
🤖 Bits Code Review · Commit 47cd7b4
What does this PR do?:
babysit-prpolls an open PR every 10 minutes; each poll spent ~13 of the 5000 hourly GraphQL points, almost all fromgh pr checks, which fetches the full CI check rollup through GraphQL (~300 contexts on a typical java-profiler PR). The poll step now reads every signal through the REST API (pulls/<n>,commits/<sha>/check-runs,commits/<sha>/status,issues/<n>/comments,pulls/<n>/reviews,pulls/<n>/comments), and idle polls back off from 10 to 20 minutes, resetting on any event. Babysitter GraphQL usage drops to zero; the shifted volume is ~8 REST requests per poll against the separate REST bucket.Motivation:
Measured on gh 2.103.3 against PR #1035 (
GH_DEBUG=apitrace +/rate_limitbefore/after):gh pr checksis 6 requests, all GraphQL, 12 points per invocation;gh pr view --jsonadds 1. A full 2-hour run costs ~156 GraphQL points per babysitter — ~3% of the hourly quota each, which multiplies with concurrent babysitters and every otherghcall sharing the token (PROF-16822).The REST calls were verified live to cover every signal the loop reads: check names, status, conclusion, details URL, check suites for reruns, status contexts (
bits-review/head,dd-gitlab/*), PR state,mergeable_state, draft, top-level comments, and review bodies. The skill also states the traps the old GraphQL command hid: RESTstateand checkstatusvalues are lowercase (open;queued,in_progress,completed— comparing against the GraphQL-cased values would stop the babysitter on an open PR or read every check as pending),--paginateemits one JSON object per page, so each read takes--jq '.check_runs[]'/.statuses[]; a head carries cancelled runs of superseded retries beside their reruns, so checks are deduped by name keeping the neweststarted_at. The thread census stays scoped to the inline-comment list; top-level comments and review bodies feed step 4's classification directly, keeping therepliedrecord on one id sequence.Dependent references updated: step 3 keys on REST
mergeable_state: dirty(lowercase) instead of GraphQLmergeStateStatus: DIRTY; step 5 takes blocking reviews from the RESTpulls/<n>/reviewslist the census already uses.Additional Notes:
gh pr checksis REST-based; the trace shows 6/6 GraphQL requests). The Bits review on this PR raised three REST-semantics findings (P1 lowercaseopenstop-guard; lost top-level comment/review sources; combined-status pagination) — all verified and fixed in bc6ee80/89a595764; the fix range was re-reviewed fresh-context (no Critical/High; two MEDIUM fixed in 89a5957, one MEDIUM + one LOW fixed in d2cb116; two LOW wording nits left, outcome-equivalent). Ticket: PROF-16822.How to test the change?:
No code change — the diff edits one skill's instructions. Validation was run against PR #1035: the REST calls reproduce
gh pr checksoutput (268 check-runs deduped by name, 30 status contexts,mergeable_state: blockedon a blocked PR), and the same reads ran live against this PR's own CI. A future babysit run on this checkout exercises the loop directly.For Datadog employees:
credentials of any kind, I've requested a security review (run the
dd:platform-security-reviewskill, or file a request via the PSEC review form).
bewairealso runs automatically on every PR.